ANW-310 - for the PUI PDF title page, use record title if there is no finding aid title #1310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated to use record display string if there is no finding aid title
|
Please check this to see if my logic and item selected to be displayed in place of finding aid title are correct to resolve this JIRA. |
some stylistic changes to h4 to make note labels less prominent
revised to make note label underlined rather than none
lmcglohon
reviewed
Jul 19, 2018
| <h1 class="title"><%= record.finding_aid['title'] %></h1> | ||
| <h2 class="subtitle"><%= record.finding_aid['subtitle'] %></h2> | ||
| <% else %> | ||
| <h1 class="title"><%== record.display_string %></h1> |
There was a problem hiding this comment.
@cdibella I think this should be <%= record.display_string %> instead of <%== record.display_string %>
There was a problem hiding this comment.
Thanks! I made that change (and removed an unrelated change I was working on). If that's too messy, just let me know if it would be better to close this one and start over fresh.
removed unneeded = to display the correct thing when there isn't a finding aid title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated to use record display string if there is no finding aid title