Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make search header message configurable #1393

Merged
merged 1 commit into from Nov 2, 2018
Merged

Make search header message configurable #1393

merged 1 commit into from Nov 2, 2018

Conversation

Blake-
Copy link
Contributor

@Blake- Blake- commented Nov 1, 2018

The current header on the /search?reset=true search page wasn't easily customized. This changes that with a new locale and a change to the _search.html.erb file.

Motivation and Context

Trying to change "Search The Archives" was nearly impossible.

How Has This Been Tested?

Brought up build locally and tested. The message is unchanged from the original, but it is now easily changed via en.yml

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • [x ] New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • [x ] My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • [ x] I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • [x ] All new and existing tests passed.

@cdibella
Copy link
Contributor

cdibella commented Nov 2, 2018

@Blake- Looks like a useful change to me - thanks for submitting it!

@cdibella cdibella merged commit 22af3ea into master Nov 2, 2018
@cdibella cdibella deleted the search_header branch November 2, 2018 12:06
@lmcglohon lmcglohon added this to the 2.5.2 milestone Nov 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants