Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ANW-704 Reverting everything but attributes and table headings #1417

Merged
merged 3 commits into from Dec 3, 2018

Conversation

lorawoodford
Copy link
Contributor

@lorawoodford lorawoodford commented Nov 30, 2018

Description

Update to reverted #1402

Adds titles and aria-labels and adds sr-only titles to table headers.

Related JIRA Ticket or GitHub Issue

https://archivesspace.atlassian.net/projects/ANW/issues/ANW-704

Motivation and Context

Improve staff-side accessibility.

How Has This Been Tested?

Visually inspected.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@lmcglohon lmcglohon added this to the 2.5.2-candidate milestone Dec 3, 2018
@lmcglohon lmcglohon changed the title Reverting everything but attributes and table headings ANW-704 Reverting everything but attributes and table headings Dec 3, 2018
@lmcglohon lmcglohon modified the milestones: 2.5.2-candidate, 2.5.2 Dec 3, 2018
@lmcglohon lmcglohon merged commit f79d970 into archivesspace:master Dec 3, 2018
@lorawoodford lorawoodford mentioned this pull request Dec 19, 2018
9 tasks
@lorawoodford lorawoodford deleted the ANW-702-new branch February 17, 2020 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants