Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ANW-670: handle deleting assessment attribute notes when deleting assessment #1543

Merged
merged 1 commit into from Apr 22, 2019

Conversation

sem42198
Copy link

Description

Handle deleting of assessment attribute notes linked to an assessment when deleting the assessment so it does not fail.

Related JIRA Ticket or GitHub Issue

ANW-670

Motivation and Context

If there is a note in the ratings section of an assessment record, you get an error when attempting to delete.

How Has This Been Tested?

Checked that you can now delete an assessment with assessment attribute notes and that it deletes the appropriate attribute notes records from the database.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@lmcglohon lmcglohon merged commit 0c74477 into archivesspace:master Apr 22, 2019
@sem42198 sem42198 deleted the ANW-670 branch April 23, 2019 18:34
@lmcglohon lmcglohon added this to the 2.6.0 milestone May 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants