Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Citations #1604

Merged
merged 9 commits into from Jun 12, 2019
Merged

Citations #1604

merged 9 commits into from Jun 12, 2019

Conversation

lorawoodford
Copy link
Contributor

Include container information and resource identifier in PUI citations when available. This is an update/extension of the work begun in #1555 .

Description

Related JIRA Ticket or GitHub Issue

https://archivesspace.atlassian.net/browse/ANW-288
https://archivesspace.atlassian.net/browse/ANW-295

Motivation and Context

The archival object and resource citations in the PUI were missing both the resource identifier and physical storage information both of which should be included.

How Has This Been Tested?

Visually inspected and existing tests pass.

Screenshots (if appropriate):

Resource with no physical containers:
Citation_work_resource
Series with no physical containers:
Citation_work_series
File with physical containers:
Citation_work_file

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@cdibella
Copy link
Contributor

@lorawoodford - looks good, but a few questions:

  • What does it look like when there are multiple containers (per our discussion of including up to 5)
  • What happens if there's no CUID?
  • What happens if there's a preferred citation note?

@lorawoodford
Copy link
Contributor Author

@cdibella

What does it look like when there are multiple containers (per our discussion of including up to 5)
With 5 instances:

Citation_work_file_5instances

With 6 instances:

Citation_work_file_6instances

What happens if there's no CUID?

Citation_work_file_noCUI

What happens if there's a preferred citation note?

Preferred citation note ALWAYS overrides all of this. If a preferred citation note is found, that is what is displayed.

@cdibella cdibella merged commit eceac8c into archivesspace:master Jun 12, 2019
@cdibella
Copy link
Contributor

Looks good! Thanks for the additional context.

@lorawoodford lorawoodford deleted the citations branch June 12, 2019 16:46
@lmcglohon lmcglohon added this to the v2.7.0 milestone Jun 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants