Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Process tree node deletes in batches #1678

Merged
merged 1 commit into from Oct 10, 2019

Conversation

mark-cooper
Copy link
Member

Small optimization for pui indexer tree node deletion. In some cases process can generate large numbers of nodes to delete (400k seen in most extreme case) so batching creates much more reasonable Solr update queries and provides more visibility in the log (vs. appearing to be "hung").

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@lmcglohon lmcglohon merged commit 24e1ffd into archivesspace:master Oct 10, 2019
@lmcglohon lmcglohon added this to the 2.8.0 milestone Oct 10, 2019
@mark-cooper mark-cooper deleted the batch_tree_deletes branch October 10, 2019 23:18
@lmcglohon lmcglohon modified the milestones: 2.8.0, 2.7.1 Feb 5, 2020
@cdibella cdibella added the community code contributed by community members not on or contracted by the ArchivesSpace program team label Mar 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community code contributed by community members not on or contracted by the ArchivesSpace program team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants