Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure alert popups retain "X" to close, but with screen reader labels #1818

Merged
merged 1 commit into from Mar 6, 2020

Conversation

lorawoodford
Copy link
Contributor

#1762 accidentally removed the "X" that allows users to close a number of ArchivesSpace alerts by placing the inside of a screen reader only class. This removes that addition and uses javascript to add an aria-label to the link for accessibility purposes.

Description

Related JIRA Ticket or GitHub Issue

How Has This Been Tested?

Confirmed visually that the X returned, utilized ChromeVox and Wave plugin to confirm that the aria-label is being presented to screen reader users. Broken Selenium tests that alerted me to this regression are now passing.

Screenshots (if appropriate):

X's missing in 2.7.1:
image

X to close back on alerts:
image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have read the CONTRIBUTING document.
  • I have authority to submit this code.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@lorawoodford lorawoodford added this to the 2.8.0 milestone Feb 28, 2020
@gwiedeman gwiedeman merged commit df7dae2 into archivesspace:master Mar 6, 2020
@lorawoodford lorawoodford deleted the alert_popup_close branch April 16, 2020 16:12
pobocks pushed a commit to harvard-library/archivesspace that referenced this pull request Apr 29, 2020
…lose

Ensure alert popups retain "X" to close, but with screen reader labels
pobocks pushed a commit to harvard-library/archivesspace that referenced this pull request Apr 30, 2020
…lose

Ensure alert popups retain "X" to close, but with screen reader labels
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants