Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ANW-1048 and ANW-1052 required column fix #1820

Merged
merged 2 commits into from Mar 2, 2020
Merged

ANW-1048 and ANW-1052 required column fix #1820

merged 2 commits into from Mar 2, 2020

Conversation

brianzelip
Copy link
Collaborator

@brianzelip brianzelip commented Mar 2, 2020 •
edited

Description

This PR solves ANW-1048 and ANW-1052 by decreasing the scope of the work in #1705 from the global populateColumnSelector to the local initColumnShowHideWidget in the Rapid Data Entry modal.

required column bug fix preview

Related JIRA Ticket or GitHub Issue

  1. ANW-1048
  2. ANW-1052

How Has This Been Tested?

Tested against the problems cited in both tickets listed above.

Screenshots (if appropriate):

See above.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have read the CONTRIBUTING document.
  • I have authority to submit this code.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@brianzelip brianzelip changed the title Anw 1048 and anw 1052 required column fix ANW-1048 and ANW-1052 required column fix Mar 2, 2020
@lorawoodford lorawoodford self-requested a review March 2, 2020 14:46
@lorawoodford lorawoodford self-assigned this Mar 2, 2020
@lorawoodford lorawoodford added this to the 2.8.0 milestone Mar 2, 2020
lorawoodford
lorawoodford reviewed Mar 2, 2020
View reviewed changes
Copy link
Contributor

@lorawoodford lorawoodford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works as desired without undoing the functionality required in [ANW-205]. Selenium tests passing again.

@lorawoodford lorawoodford merged commit a3e2c56 into archivesspace:master Mar 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lorawoodford lorawoodford lorawoodford left review comments

Assignees

@lorawoodford lorawoodford

Labels
None yet
Projects
None yet
Milestone
2.8.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@brianzelip @lorawoodford