Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements to top container indicator column sort #1890

Conversation

Hurlyburly2
Copy link

Description

This change improves the sorting of the indicator column when viewing the results of a search for top containers. It especially improves results on mixed alphabetical + numeric indicators, and no longer sorts by string length.

Related JIRA Ticket or GitHub Issue

How Has This Been Tested?

Manual testing, and this passes the indicator sort test that already exists in the "searches containers and performs bulk operations" block.

Screenshots (if appropriate):

old behavior:
indicatorsort_old

new behavior:
indicatorsort_new

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have read the CONTRIBUTING document.
  • I have authority to submit this code.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@Hurlyburly2 Hurlyburly2 changed the title Arcpsc 668 improvements to indicator column sort for core Improvements to top container indicator column sort May 8, 2020
@mark-cooper mark-cooper self-requested a review May 11, 2020 17:59
@mark-cooper
Copy link
Member

LGTM 👍

@lorawoodford lorawoodford added the community code contributed by community members not on or contracted by the ArchivesSpace program team label May 18, 2020
@mark-cooper mark-cooper added this to the 2.8.0 milestone May 18, 2020
@mark-cooper mark-cooper merged commit b050a96 into archivesspace:master May 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community code contributed by community members not on or contracted by the ArchivesSpace program team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants