Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-1920 --A-- Fix duplicate js imports, but not xhr sync warning #1938

Conversation

brianzelip
Copy link
Collaborator

@brianzelip brianzelip commented Jun 29, 2020

This PR is the first of 3 proposed solutions to #1920 (see there for info about all 3 PRs).

This only fixes the duplicated imports by moving the include_tag up the DOM and out of the template loop.

This does not fix the synchronous xhr warning.

Description

Related JIRA Ticket or GitHub Issue

#1920

How Has This Been Tested?

Screenshots (if appropriate):

See #1920

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have read the CONTRIBUTING document.
  • I have authority to submit this code.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@lorawoodford lorawoodford self-assigned this Jul 20, 2020
@lorawoodford lorawoodford added the contractor Work completed by program-employed contract developers label Aug 4, 2020
@lorawoodford
Copy link
Contributor

Closing in favor of #1936

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contractor Work completed by program-employed contract developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants