Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix to agent handler assigning wrong agents #2032

Merged
merged 2 commits into from Oct 27, 2020

Conversation

bobbi-SMR
Copy link
Contributor

Description

The call to stored, the method used to see if an agent has previously been processed (and its information stored locally had an incorrectly created parameter.

This solves the problem of, once an agent of a particular type (person, corporate, family) is created, it is applied as the agent for any subsequent archival objects that have an arbitrary agent of the same type.

Related JIRA Ticket or GitHub Issue

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • [X ] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • [ X] My code follows the code style of this project.
  • My change requires a change to the documentation.
  • [ X] I have read the CONTRIBUTING document.
  • I have authority to submit this code.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@lorawoodford lorawoodford added community code contributed by community members not on or contracted by the ArchivesSpace program team hacktoberfest-accepted PRs submitted during the Hacktoberfest 2020 challenge! labels Oct 26, 2020
@lorawoodford lorawoodford added this to the 2.8.1 milestone Oct 26, 2020
@mark-cooper
Copy link
Member

Thx @bobbi-SMR

@mark-cooper mark-cooper merged commit efdec24 into archivesspace:master Oct 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community code contributed by community members not on or contracted by the ArchivesSpace program team hacktoberfest-accepted PRs submitted during the Hacktoberfest 2020 challenge!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants