optimize deletion of notes attached to subrecords

[quoideneuf]

Use the same Sequel optimization when removing subnote metadata from nested sub-records that have notes as is used for top-level records.

The resulting change in the SQL statements is as follows:
Before:
DELETE FROM subnote_metadata WHERE (note_id IN (SELECT id FROM note WHERE (rights_statement_id IN (27))))
After:
DELETE subnote_metadata FROM subnote_metadata INNER JOIN note ON (note.id = subnote_metadata.note_id) WHERE (rights_statement_id IN (27))

Related JIRA Ticket or GitHub Issue

#2275

How Has This Been Tested?

Wrote test coverage for updating records with sub records with notes.

Screenshots (if appropriate):

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

• My code follows the code style of this project.
• My change requires a change to the documentation.
• I have read the CONTRIBUTING document.
• I have authority to submit this code.
• I have added tests to cover my changes.
• All new and existing tests passed.