Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ANW-730: Add PUI expand/collapse all config option #2538

Merged

Conversation

brianzelip
Copy link
Collaborator

@brianzelip brianzelip commented Dec 3, 2021

This PR solves ANW-730 by adding a global PUI config option for toggling on/off the "expand all information blocks" by default at the bottom of record pages.

⚠️ The expand all option has been set to true by default. ⚠️

anw-730-pui-expand-all

Description

  1. Add new config option to common/config/config-defaults.rb
  2. Add new parameter to initialize_accordion(), clean up handle_accordion.js
  3. Pass new arguments to uses of initialize_accordion()
  4. Add tests

Related JIRA Ticket or GitHub Issue

ANW-730

How Has This Been Tested?

See public/spec/features/record_accordion_spec.rb

Screenshots (if appropriate):

See above

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
    • Documentation has been updated
  • I have read the CONTRIBUTING document.
  • I have authority to submit this code.
  • I have added tests to cover my changes.
    • All new and existing tests passed.

@brianzelip
Copy link
Collaborator Author

@quoideneuf hope this is consistent with making AS config options available.

@brianzelip
Copy link
Collaborator Author

Updated tech-docs to reflect this new config option, archivesspace/tech-docs#124.

@brianzelip brianzelip marked this pull request as ready for review December 5, 2021 12:03
@brianzelip
Copy link
Collaborator Author

@quoideneuf This PR is now ready for review.

@quoideneuf quoideneuf merged commit 6925d39 into archivesspace:master Jan 18, 2022
@cdibella cdibella added this to the 3.2.1 milestone Apr 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants