add i18n to frontend and public interface footers #2586
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Footers of public and frontend interface were not ready for i18n. I have changed that and added three new translation keys each to the
en.yml
files of frontend and public components. They live underfooter
. This was inspired by the already existingheader
in the frontend component.I'm unsure if relevant keys need to be added to other languages as well. If so, please point this out.
I'm unsure why I had to use the
I18n.t().html_safe
in the public footer. This was not necessary in the frontend footer. If this is a problem, please tell me.Related JIRA Ticket or GitHub Issue
Fixes #2583
How Has This Been Tested?
Visual testing by running the frontend and public interfaces locally.
Could not run automated tests locally because of
You have already activated nokogiri 1.12.4, but your Gemfile requires nokogiri 1.12.3
. Not sure what I'm doing wrong.Screenshots (if appropriate):
Types of changes
Checklist: