Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ANW-1168: strip out quotes from the confimration when deleting a repo #2604

Merged
merged 1 commit into from Jan 26, 2022

Conversation

avatar382
Copy link
Collaborator

Description

Single quotes are not being escaped properly by translations and JS layers, so trying to delete a repo with a single quote in the name leads to an unexpected string in the confirmation. This removes quptes from the confirmation to bypass this issue while still allowing for single quotes in repo names.

Related JIRA Ticket or GitHub Issue

https://archivesspace.atlassian.net/jira/software/c/projects/ANW/issues/ANW-1168

How Has This Been Tested?

Manual in browser and unit testing

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have read the CONTRIBUTING document.
  • I have authority to submit this code.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@quoideneuf quoideneuf self-assigned this Jan 26, 2022
@quoideneuf quoideneuf merged commit f3caacf into master Jan 26, 2022
@quoideneuf quoideneuf deleted the ANW-1168 branch January 26, 2022 21:10
@cdibella cdibella added this to the 3.2.1 milestone Apr 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants