Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ANW-1268: bugfix for invalid EAD created when top_container.type left blank #2608

Merged
merged 3 commits into from Mar 4, 2022
Merged

ANW-1268: bugfix for invalid EAD created when top_container.type left blank #2608

merged 3 commits into from Mar 4, 2022

Conversation

avatar382
Copy link
Collaborator

Description

Bugfix

Related JIRA Ticket or GitHub Issue

https://archivesspace.atlassian.net/jira/software/c/projects/ANW/issues/ANW-1268

How Has This Been Tested?

manual, in browser testing

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have read the CONTRIBUTING document.
  • I have authority to submit this code.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@avatar382 avatar382 marked this pull request as draft January 13, 2022 15:56
@avatar382 avatar382 marked this pull request as ready for review March 3, 2022 18:32
@mark-cooper mark-cooper self-assigned this Mar 4, 2022
@mark-cooper mark-cooper merged commit 0b11a23 into master Mar 4, 2022
@mark-cooper mark-cooper deleted the ANW-1268 branch March 4, 2022 23:58
@cdibella cdibella added this to the 3.2.1 milestone Apr 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mark-cooper mark-cooper mark-cooper approved these changes

Assignees

@mark-cooper mark-cooper

Labels
None yet
Projects
None yet
Milestone
3.3.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@avatar382 @mark-cooper @cdibella