Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration 158 Legacy Data Issues #2616

Merged
merged 2 commits into from Jan 21, 2022
Merged

Migration 158 Legacy Data Issues #2616

merged 2 commits into from Jan 21, 2022

Conversation

quoideneuf
Copy link
Collaborator

@quoideneuf quoideneuf commented Jan 19, 2022

Adds 2 small modifications to the ARK migration adopted here: #2472

  1. Ensure that duplicate "zombie" rows are deleted before and after the first big transaction.
  2. Ensure that the user is warned and the migration is aborted if legacy data contains a one-to-many ARK-to-Resource relation.

Description

Related JIRA Ticket or GitHub Issue

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have read the CONTRIBUTING document.
  • I have authority to submit this code.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@quoideneuf quoideneuf marked this pull request as ready for review January 20, 2022 21:22
@quoideneuf quoideneuf changed the title delete ark_name rows that point to missing objects before and after t… Migration 158 Legacy Data Issues Jan 20, 2022
@mark-cooper mark-cooper merged commit 260b065 into master Jan 21, 2022
@mark-cooper mark-cooper deleted the ark-migration-trouble branch January 21, 2022 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants