API login request with expiring=false now returns feedback #2620
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously, if you tried to send a curl request with expiring=false, it would return successful regardless of if the param was successful. For example
curl -s -F password="admin" expiring=false "http://localhost:8089/users/admin/login"
would return successfully, but the token would expire because it should be `curl -s -F password="admin" "http://localhost:8089/users/admin/login?expiring=false"Now, when you send the expiring param the correct way, the response will include a expire_after_seconds field which shows the number of seconds until the token expires. This is set by
AppConfig[:session_nonexpirable_force_expire_after_seconds]
Related JIRA Ticket or GitHub Issue
N/A
How Has This Been Tested?
ran it in devserver mode and gave it curl requests to the backend.
Screenshots (if appropriate):
Types of changes
Checklist:
Not sure if there should tests for this, but just let me know if so and I'll try to include them.