Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update merge subject api python example for #2519 #2632

Merged
merged 1 commit into from Feb 25, 2022
Merged

Update merge subject api python example for #2519 #2632

merged 1 commit into from Feb 25, 2022

Conversation

crugas
Copy link
Contributor

@crugas crugas commented Feb 4, 2022

Description

Better detail for the python example - comments to help people understand the code

Related JIRA Ticket or GitHub Issue

#2519

How Has This Been Tested?

No testing necessary

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have read the CONTRIBUTING document.
  • I have authority to submit this code.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@crugas crugas marked this pull request as ready for review February 4, 2022 21:20
@crugas crugas mentioned this pull request Feb 4, 2022
Merged
9 tasks
@quoideneuf quoideneuf merged commit e26ad15 into archivesspace:master Feb 25, 2022
@cdibella cdibella added this to the 3.2.1 milestone Apr 27, 2022
@cdibella cdibella added the community code contributed by community members not on or contracted by the ArchivesSpace program team label Aug 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@quoideneuf quoideneuf quoideneuf approved these changes

Assignees
No one assigned
Labels
community code contributed by community members not on or contracted by the ArchivesSpace program team
Projects
None yet
Milestone
3.3.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@crugas @quoideneuf @cdibella