Record Inheritance resolve updates #2637
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make the RI resolve list configurable. Improve performance of RI by removing ancestor instances from the list to resolve by default. For the PUI ancestors processing has no clear need for instances by default (it is not part of the default RI config), but it can have a negative impact on performance when there are many linked containers through the ancestors. Have observed 3x indexing speed improvement for some batches using default config by removing this.
That change made the build job for rspec use bundler to invoke...thus breaking all the places we don't use bundler and so are able to just let the Gemfile contain stuff that is unique to that app.
quoideneuf
approved these changes
Feb 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the RI resolve list configurable.
Improve performance of RI by removing ancestor instances from
the list to resolve by default.
For the PUI ancestors processing has no clear need for instances
by default (it is not part of the default RI config), but it can
have a negative impact on performance when there are many linked
containers through the ancestors. Have observed 3x indexing speed
improvement for some batches using default config by removing this.
Checklist: