Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ANW-1493 Representative File Version: Backend Rules #2644

Merged
merged 2 commits into from Mar 4, 2022
Merged

ANW-1493 Representative File Version: Backend Rules #2644

merged 2 commits into from Mar 4, 2022

Conversation

brianzelip
Copy link
Collaborator

@brianzelip brianzelip commented Feb 23, 2022 •
edited

Description

  • Adds representative_file_version field to digital_object schema
  • Adds representative_file_version computed property to digital_object model per business logic
  • Adds validate method to file_version model per business logic
  • Adds tests per business logic

Related JIRA Ticket or GitHub Issue

ANW-1493

How Has This Been Tested?

See backend/spec/model_digital_object_spec.rb

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have read the CONTRIBUTING document.
  • I have authority to submit this code.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@brianzelip
Add representative_file_version field to digital_object schema
d7b3d16 
Add representative_file_version computed prop to dig obj model,
Add validate method to file_version model,
Add tests.
@brianzelip brianzelip marked this pull request as ready for review March 3, 2022 21:30
@brianzelip brianzelip changed the title [WIP] ANW-1493 Representative File Version: Backend Rules ANW-1493 Representative File Version: Backend Rules Mar 3, 2022
@quoideneuf quoideneuf self-assigned this Mar 4, 2022
@quoideneuf quoideneuf merged commit eaf639e into archivesspace:master Mar 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@quoideneuf quoideneuf quoideneuf approved these changes

Assignees

@quoideneuf quoideneuf

Labels
notfor3.3.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@brianzelip @quoideneuf @cdibella