ANW-1422: display full record ID in PUI breadcrumb #2646
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mark-cooper
reviewed
Mar 4, 2022
| @@ -28,7 +28,15 @@ def breadcrumb | |||
| def breadcrumb_identifier(record, type) | |||
| case type | |||
| when 'resource' | |||
| resolved_resource['id_0'] if resolved_resource | |||
| if resolved_resource | |||
| id_0 = resolved_resource['id_0'] | |||
There was a problem hiding this comment.
@avatar382 an alternative could be resolved_resource.slice('id_0', 'id_1', 'id_2', 'id_3').values.compact.join('-') ... but if you want to leave it as is I think we're good here, works as expected.
mark-cooper
approved these changes
Mar 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
display full record ID in PUI breadcrumb
Related JIRA Ticket or GitHub Issue
https://archivesspace.atlassian.net/jira/software/c/projects/ANW/issues/ANW-1422
How Has This Been Tested?
manual in browser testing
Screenshots (if appropriate):
Types of changes
Checklist: