Note persistent id issue #2649
Merged
Note persistent id issue #2649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quoideneuf
force-pushed
the
note-persistent-id-issue
branch
from
25c8607
to
281cb03
Compare
lorawoodford
approved these changes
Mar 10, 2022
There was a problem hiding this comment.
@quoideneuf Sorry for the slow reply to this, but thanks for catching this! This looks good to me, with the caveat that I don't really have any real-life messy dbs hanging around to fully test the migration. But everything looks right.
I was pretty surprised how hard it was to trace a note (whether single- or multi-part) back up to it's parent record. I considered making a helper method to do it, but this had already gotten far more complex than I thought it should be.
Thanks again!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-submission of #2627 (see that PR for original description).
While testing, I realized that certain previous migrations (088, 142) that transformed legacy data into notes failed to populate the
note_persistent_idtable while populating thenotetable. This is a fairly obscure omission, but could break the note-referencing functionality that supports index notes.