Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ANW-1506 Display representative file version in PUI #2656

Merged

Conversation

brianzelip
Copy link
Collaborator

@brianzelip brianzelip commented Mar 5, 2022

This PR closes ANW-1506 by displaying a digital object's representative file version in the public interface.

ANW-1506 render digital object representative file version image

Description

  • Render image file uri in PUI digital object record
  • Add representative_file_verson to objects controller
  • Update locals passed to digital partial in objects show template
  • Add representative_file_version template
  • Refactor digital template around new rep fv template
  • Add representative fv helper to resource controller
  • Pass representative fv local in resource show view
  • Add tests to digital_objects_controller_spec.rb

@brianzelip brianzelip force-pushed the ANW-1506-pui-display-rep-img branch 3 times, most recently from a401682 to c2d2302 Compare March 15, 2022 17:21
@brianzelip brianzelip marked this pull request as ready for review March 15, 2022 17:29
@brianzelip brianzelip changed the title [WIP] ANW-1506 Display representative file version in PUI ANW-1506 Display representative file version in PUI Mar 15, 2022
@quoideneuf quoideneuf self-assigned this Mar 15, 2022
Copy link
Collaborator

@quoideneuf quoideneuf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are breaking some existing functionality that used logic in the public controller and templates to work out whether to display the image or an icon based on various file version properties. But I am going to sort through that separately.

@quoideneuf quoideneuf merged commit 65ce43b into archivesspace:master Mar 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants