Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ANW-1483: correct maintenance states strings in EAC-CPF export #2659

Merged
merged 3 commits into from Mar 25, 2022

Conversation

avatar382
Copy link
Collaborator

Description

Correcting export strings so they conform to EAC/CPF

Related JIRA Ticket or GitHub Issue

https://archivesspace.atlassian.net/jira/software/c/projects/ANW/issues/ANW-1483

How Has This Been Tested?

manual and unit testing

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have read the CONTRIBUTING document.
  • I have authority to submit this code.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@cdibella
Copy link
Contributor

@avatar382 thanks for doing this. Looking at the file changes, I think this line at the end of the JIRA may have slipped your notice:

"Also, an additional status of deletedMerged is needed."

@quoideneuf quoideneuf merged commit b73b27a into master Mar 25, 2022
@quoideneuf quoideneuf deleted the ANW-1483 branch March 25, 2022 12:31
@cdibella cdibella added this to the 3.2.1 milestone Apr 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants