Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ANW-1548 Unexpected digital object bulk import requirement of DO uri or thumbnail #2695

Merged
merged 1 commit into from Apr 29, 2022

Conversation

brianzelip
Copy link
Collaborator

@brianzelip brianzelip commented Apr 29, 2022

Description

A user noticed that bulk importing digital objects via spreadsheet failed after upgrading from v2.8.1 to v3.2.0 due to an unexpected requirement for a value in either the digital_object_link or thumbnail columns in the bulk_import_DO_template.xlsx file.

The link or thumbnail requirement was added on March 27, 2021 via this commit. (Indeed after v2.8.1 release.)

This PR removes the requirement, essentially resetting the code back to the v2.8.1 state.

It's likely either the case that

  • there was an explicit decision to add the requirement, and the instructions in the xlsx file were not updated accordingly, or
  • the requirement wasn't an explicit design decision and therefore the instructions weren't updated and the behavior was not seen as a problem until now.

Another PR solution for this ticket would be to keep the requirement and update the instructions to include the requirement.

Related JIRA Ticket or GitHub Issue

ANW-1548

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have read the CONTRIBUTING document.
  • I have authority to submit this code.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link
Collaborator

@quoideneuf quoideneuf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏

@quoideneuf quoideneuf merged commit 8119f9a into master Apr 29, 2022
@quoideneuf quoideneuf deleted the ANW-1548-DO-load-spreadsheet branch April 29, 2022 18:25
@cdibella cdibella added this to the 3.2.1 milestone May 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants