Chore: Upgrade ESLint and Stylelint major versions #2696
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR upgrades ESLint from v7 to v8, and Stylelint (plus related dependencies) from v13 to v14.
There are no significant changes to mention regarding ES lint.
Stylelint decreased its core scope to focus only on CSS, not Sass, Less, etc, so the tooling pipeline changed. Scss files are still first class citizens. But Less is now secondary as it becomes less fashionable, and as such has to reach into a PostCSS plugin for a new "custom syntax override" behavior. New lint rules were also introduced. This PR fixes errors from new linting rules and updates the config.
Description
Related JIRA Ticket or GitHub Issue
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: