Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ANW-1360: adding URI to list of fields that can be displayed in search/browse #2697

Merged
merged 2 commits into from May 25, 2022

Conversation

avatar382
Copy link
Collaborator

Description

adding URI to list of fields that can be displayed in search/browse

Related JIRA Ticket or GitHub Issue

https://archivesspace.atlassian.net/jira/software/c/projects/ANW/issues/ANW-1360

How Has This Been Tested?

in browser testing

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have read the CONTRIBUTING document.
  • I have authority to submit this code.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@cdibella cdibella added this to the 3.3.0 milestone May 5, 2022
@mark-cooper mark-cooper self-assigned this May 12, 2022
@mark-cooper
Copy link
Member

Hi @avatar382 b4 I try this out I notice that uri is in all caps (URI) as a key in common/config/search_browse_column_config.rb and frontend/config/locales/en.yml. Is that intentional for some reason? I think that's fine for the label but convention would be to keep it lowercase (uri) for the keys.

Copy link
Member

@mark-cooper mark-cooper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Request: "let’s do it for every browse and search setting, trivial".
https://archivesspace.atlassian.net/wiki/spaces/AC/pages/3022716936/2022-02-01+Meeting+notes

  1. There are some configurable browse columns for record types without
    the uri option added (for example "events").
  2. Uri has not been added to the search columns config (called "multi"
    in the common/config/search_browse_column_config.rb). Any reason for that?
  3. Should use lower case keys in common/config/search_browse_column_config.rb
    and frontend/config/locales/en.yml.

@quoideneuf quoideneuf self-assigned this May 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants