ANW-1474 refactor agent required field customization form

[quoideneuf]

Rework the agents/agent_type/required form:

• change the semantics of the required_field blob so that presence of jsonmodel_type indicates sub record is required; replace 'REQ' with the JSONModel type of the subrecord being required.
• add tests
• stop using the FormContext template definitions and emitters, as these were adding unneeded templates all over the places.
• etc.

Related JIRA Ticket or GitHub Issue

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

• My code follows the code style of this project.
• My change requires a change to the documentation.
• I have read the CONTRIBUTING document.
• I have authority to submit this code.
• I have added tests to cover my changes.
• All new and existing tests passed.

[mark-cooper]

On the technical side everything LGTM. This is a nice refactor!

I found a couple of minor UI "issues" (which can probably be ignored for now):

1. Where there's a mandatory subrecord the checkbox for "Require Subrecord" should be checked and unmodifiable? (example: Name Form)
2. When creating a record with required subrecords the required subrecords should have the required icon (asterisk) like fields do? (example: when Genders is a required subrecord it isn't visually clear that you need to select from the dropdown, until saving and getting an error. Translation missing: validation_errors.database_integrity_constraint_conflict__java__javasql__sqlexception__field__gender_id__doesn_t_have_a_default_value)
3. Genders is in the create Required Fields form (agent person) but not in the sidebar.

In the interests of moving this forward for testing should I merge now and let the issues be resolved later if necessary / relevant?

[cdibella]

Thanks for doing this @quoideneuf and for reviewing/merging it @mark-cooper ! When this is returned to in order to clean up the issues noted above, the WAVE tool flags a number of things, mostly missing or orphaned form labels within the main panel.