Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ANW-1134: Avoid resolving top_containers where it's unnecessary #2708

Merged

Conversation

mark-cooper
Copy link
Member

Remove 'top_container_uri_u_sstr:id' from default search opts in
controllers where it isn't required / used.

Not only is it unnecessary but it can wreak havoc in general
searches where the search returns records containing many
instances, resulting in "too many boolean clauses".

For the latter issue we now pre-check for subqueries that
exceed our defined limit (default 1024) and drop the excess
conditions with a warning, equivalent to the max resolve warning.

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have read the CONTRIBUTING document.
  • I have authority to submit this code.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@quoideneuf quoideneuf self-assigned this Jul 21, 2022
Remove 'top_container_uri_u_sstr:id' from default search opts in
controllers where it isn't required / used.

Not only is it unnecessary but it can wreak havoc in general
searches where the search returns records containing many
instances, resulting in "too many boolean clauses".

For the latter issue we now pre-check for subqueries that
exceed our defined limit (default 1024) and drop the excess
conditions with a warning, equivalent to the max resolve warning.
@mark-cooper mark-cooper changed the title ANW-1374: Avoid resolving top_containers where it's unnecessary ANW-1134: Avoid resolving top_containers where it's unnecessary Jul 21, 2022
@mark-cooper mark-cooper marked this pull request as ready for review July 21, 2022 18:41
@mark-cooper mark-cooper added this to the 3.3.0 milestone Jul 21, 2022
@quoideneuf quoideneuf merged commit fc0e3ca into archivesspace:master Jul 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants