Hide 'View Published' for published records in unpublished repositories

[andrew-morrison]

Description

Currently, the 'View Published' toolbar button in the staff interface is hidden for unpublished records. However, it is still visible for records (resources, archival objects, digital objects, accessions) which belong to a repository which isn't published. Clicking the button in such cases returns a 404 page, as it should, but the presence of the button could make people incorrectly think they are published. It is a minor issue, but can cause confusion, if using an unpublished repository as a staging area.

This change fixes that, by adding a new condition that must be met for the button to be displayed:

if current_repo.publish || !record.repository

The second clause is needed to allow global records (e.g. agents) that don't belong to the repository the staff user has currently activated to be previewed.

Related JIRA Ticket or GitHub Issue

None

How Has This Been Tested?

On development system (and in a local plug-in on a production system.)

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

• My code follows the code style of this project.
• My change requires a change to the documentation.
• I have read the CONTRIBUTING document.
• I have authority to submit this code.
• I have added tests to cover my changes.
• All new and existing tests passed.