Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assessment View Delete Button Visibility #2733

Merged

Conversation

jdshaw
Copy link
Contributor

@jdshaw jdshaw commented Jun 29, 2022

Fixes visibility of delete button on assessment views for users without delete permission

Description

Minor change to view for below issue.

The delete button on the assessment edit/view was visible to users without the correct permissions (delete_assessment_record)

Related JIRA Ticket or GitHub Issue

How Has This Been Tested?

Manual testing in local dev instance

Mac O/S running the packaged docker containers with dev db.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have read the CONTRIBUTING document.
  • I have authority to submit this code.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

- fixes visibility of delete button on assessment views for users without delete permission
@cdibella cdibella added this to the 3.3.0 milestone Jul 11, 2022
@mark-cooper mark-cooper self-assigned this Jul 13, 2022
@mark-cooper mark-cooper merged commit c804cbb into archivesspace:master Jul 19, 2022
@cdibella cdibella added the community code contributed by community members not on or contracted by the ArchivesSpace program team label Aug 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community code contributed by community members not on or contracted by the ArchivesSpace program team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants