fix GITHUB_TOKEN secret #2869
Merged
fix GITHUB_TOKEN secret #2869
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brianzelip
reviewed
Nov 30, 2022
There was a problem hiding this comment.
In looking at the ad-m/github-push-action docs, I see they set persist-credentials: false during the checkout step, which impacts the secrets.GITHUB_TOKEN used in the Push changes step.
Were you able to run the new workflow and see it work as expected?
brianzelip
reviewed
Nov 30, 2022
There was a problem hiding this comment.
Also, I don't have access to the repo's settings, so I can't review the permissions for the GITHUB_TOKEN as described in the docs.
|
It appears to work in my repository, but I can't say I know for sure that it will work in this one. I hope so! |
brianzelip
approved these changes
Nov 30, 2022
|
This just needs rebasing w/ master |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an incorrect GitHub Actions secret reference, and adds an option to fetch stats by pushing to
fetches-download-stats-on-push. Also includes last month's download.