ANW-1426: don't display local access restriction type when not approp…

[avatar382]

…riate

Description

Don't display Local Access Restriction Type form label when not appropriate in notes show view template

Related JIRA Ticket or GitHub Issue

https://archivesspace.atlassian.net/browse/ANW-1426

How Has This Been Tested?

manual in browser testing

Screenshots (if appropriate):

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

• My code follows the code style of this project.
• My change requires a change to the documentation.
• I have read the CONTRIBUTING document.
• I have authority to submit this code.
• I have added tests to cover my changes.
• All new and existing tests passed.

[quoideneuf]

See inline comment - label still shows in cases where the note never had a local_access_restriction_type value.

[cdibella]

@donaldjosephsmith Is there something else Manny needs to do on this before it can be reviewed? It looks like he submitted a fix in September in response to Brian H.'s request from May.

[donaldjosephsmith]

Looks like what Brian mentioned was addressed.

suggested change implemented and Brian is no longer a reviewer