ANW-1635: display linked record title/display strings when downloadin…

[avatar382]

…g CSV

Description

display linked record title/display strings when downloading CSV files

Related JIRA Ticket or GitHub Issue

https://archivesspace.atlassian.net/browse/ANW-1635

How Has This Been Tested?

Manual and unit testing

Screenshots (if appropriate):

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

• My code follows the code style of this project.
• My change requires a change to the documentation.
• I have read the CONTRIBUTING document.
• I have authority to submit this code.
• I have added tests to cover my changes.
• All new and existing tests passed.

[quoideneuf]

I am not sure whether to merge this or to address the more general problem of CSV downloads of search results. This seems to be part of a larger issue which arises from the CSV downloads being obtained directly from Solr using the csv writer type. While it is convenient to let Solr do the transformation to CSV, it breaks at least two pieces of functionality: 1) the backend's SearchResolver, which converts references into configurable representations of objects (like a title or display string), and 2) I18n translations. So there is a recurring problem of references or complex fields not appearing in CSV tables, and of enumerations remaining untranslated. Until now, people have solved this problem by adding stored fields to the Solr schema to try to match the data as it looks in the HTML results table. Aside from being messy, it doesn't always result in a perfect match. Furthermore, requests to the backend /search endpoint that include the dt=csv and a resolve[]= param will raise errors, because the Search.search method tries to run the csv formatted data through the SearchResolver.

So maybe it is worth looking into a new approach that will wrap json-formatted Solr results as CSV in the backend, after the data have been resolved, translated, etc.

See also:

https://archivesspace.atlassian.net/browse/ANW-1190
https://archivesspace.atlassian.net/browse/ANW-1365
https://archivesspace.atlassian.net/browse/ANW-695

And note that the new representative_file_version field shows up as a blank field in CSV results as well.

[brianzelip]

After you change the migration file name to start w/ '175', I'll nurse the tests until passing and merge.

[avatar382]

After you change the migration file name to start w/ '175', I'll nurse the tests until passing and merge.

Got the migration renumbered, and rebased against the current master.

[brianzelip]

Thanks! We decided to punt on the issue mentioned in the comments in order to merge the work provided here.