ANW-1690 ensure record link after +1 event #2980
Conversation
Adds the record uri and type to the "plus 1" button parameters so the record will again be linked automatically on the new event form.
Changes the Cancel button/link to go to the original resource that new events were being linked to instead of just going back in the browser. Going back is not useful when a user is adding more than one event.
There was a problem hiding this comment.
Nice work @donaldjosephsmith! The test works well, I think waiting on the aria attribute to show up is a good approach.
As an aside, it bugs me that in the tests some DOM elements have to be grabbed by near-anonymous selectors like div.resource. I've been slowly adding unique identifiers to markup, often viadata-* attributes rather than classes.
|
@brianzelip @donaldjosephsmith Was this one ready to merge? The JIRA is marked Ready for Testing and from Brian's comment above it sounds like it's good to go, but it's still open and I'm still seeing the original bug on the test server. |
|
@cdibella it hasn’t been merged into master since it’s not related to rep file version. |
|
(So the Jira status was changed too early) |
Adds the record URI and type to the "plus 1" button parameters so the record will again be linked automatically on the new event form.