Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugins can add to top of body in PUI #2998

Merged

Conversation

jdshaw
Copy link
Contributor

@jdshaw jdshaw commented May 10, 2023

Allows plugins to add content directly to top of the body of the page in the PUI

Description

Adds another plugin hook to layout to allow plugins to directly add content to the top of the body of PUI pages. Use case example: adding <noscript> content for things like Google Tag Manager.

Related JIRA Ticket or GitHub Issue

How Has This Been Tested?

Local testing Mac OS

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have read the CONTRIBUTING document.
  • I have authority to submit this code.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@quoideneuf quoideneuf merged commit 616638d into archivesspace:master May 26, 2023
8 checks passed
@cdibella cdibella added the community code contributed by community members not on or contracted by the ArchivesSpace program team label Aug 28, 2023
@cdibella cdibella added this to the 3.5.0 milestone Aug 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community code contributed by community members not on or contracted by the ArchivesSpace program team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants