use correct field in migration

[ph448]

Description

Migration 160 currently fails for us, but probably produces incorrect results for everyone due to using an incorrect field, see issue #3022 for details

Related GitHub Issue

Fixes #3022

How Has This Been Tested?

I've built a release from the fix branch, installed it on our test system and was able to run the migration successfully.

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

• My code follows the code style of this project.
• My change requires a change to the documentation.
• I have read the CONTRIBUTING document.
• I have authority to submit this code.
• I have added tests to cover my changes.
• All new and existing tests passed.

[quoideneuf]

@ph448 thanks! will take a look at this asap.

[quoideneuf]

@ph448
I tested both the original version of this migration and your change and got the same results. Here is the test I did:

• Started V2.8.1 with a blank database
• Created an agent_person with an agent contact with a note
• Confirmed the note data appeared in the agent_contact table
• Upgraded to V3.2.0
• Confirmed the note data now appears in the note table
• Confirmed the note data has no corresponding row in the note_persistent_id table
• Upgraded to V3.4.0
• Confirmed the note data now has a corresponding row in the note_persistent_id table
• Rolled back the database to V3.2.0
• Checkout out your branch and ran the db migration
• Confirmed the note data now has a corresponding row in the note_persistent_id table
  So assuming this change resolved the issue you discovered, I think it should be a fine change.