ANW-1101 Top Container mgmt browse column prefs - take 2 #3058
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to an incomplete understanding, the previous attempt hijacked the existing Top Container browse column preferences. This version uses a separate section in the preferences specified as Top Container Management to distinguish it from the Top Container tables that already exist in certain subrecord areas.
brianzelip
reviewed
Oct 10, 2023
| @@ -2407,6 +2407,7 @@ en: | |||
| event_browse_section: Event Browse Columns | |||
| collection_management_browse_section: Collection Management Browse Columns | |||
| top_container_browse_section: Top Container Browse Columns | |||
| top_container_mgmt_browse_section: Top Container Management Browse Columns | |||
There was a problem hiding this comment.
Should this key be renamed top_container_mgmt_browse_column?
brianzelip
reviewed
Oct 10, 2023
|
|
||
| click_button 'Save Preferences' | ||
| visit '/top_containers' | ||
| select 'No', from: 'exported' | ||
| click_button 'Search' | ||
| expect(find('th.header.headerSortDown')).to have_content('URI') | ||
| expect(find('th.header.headerSortDown')).to have_content('ILS Holding ID') | ||
| expect(page).to have_content('ILS Holding ID') |
There was a problem hiding this comment.
Minor, but this line seems redundant now given the updated line above.
brianzelip
reviewed
Oct 10, 2023
brianzelip
approved these changes
Oct 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to an incomplete understanding, the previous attempt hijacked the existing Top Container browse column preferences. This version uses a separate section in the preferences specified as Top Container Management to distinguish it from the Top Container tables that already exist in certain subrecord areas.