Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use instance variable to speedup context cell (lookup ancestor titles) #3065

Merged

Conversation

mark-cooper
Copy link
Member

This updates: #3025

Additional testing has been done to ensure the instance variable is valid in all views (hence initted in application controller).

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have read the CONTRIBUTING document.
  • I have authority to submit this code.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

This updates:
archivesspace#3025

Additional testing has been done to ensure the instance variable
is valid in all views (hence initted in application controller).
@mark-cooper mark-cooper marked this pull request as ready for review October 24, 2023 20:43
@cdibella cdibella added this to the 3.5.0 milestone Oct 25, 2023
@donaldjosephsmith donaldjosephsmith merged commit 087f87a into archivesspace:master Nov 20, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants