Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ANW-1848: Fixes for PUI PDF issues from review #3078

Merged
merged 6 commits into from
Jan 11, 2024
Merged

ANW-1848: Fixes for PUI PDF issues from review #3078

merged 6 commits into from
Jan 11, 2024

Conversation

avatar382
Copy link
Collaborator

Description

Fixes for PUI PDF issues from review

Related JIRA Ticket or GitHub Issue

https://archivesspace.atlassian.net/browse/ANW-1848

How Has This Been Tested?

manual testing

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have read the CONTRIBUTING document.
  • I have authority to submit this code.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@avatar382 avatar382 marked this pull request as draft November 17, 2023 17:43
@cdibella cdibella added this to the 3.5.0 milestone Dec 8, 2023
@avatar382 avatar382 marked this pull request as ready for review December 14, 2023 18:21
@brianzelip brianzelip self-assigned this Jan 3, 2024
@brianzelip brianzelip self-requested a review January 3, 2024 16:59
brianzelip
brianzelip requested changes Jan 8, 2024
View reviewed changes
Copy link
Collaborator

@brianzelip brianzelip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@avatar382 All of the TODO points in the ticket have been fixed except for:

In the Table of Contents, dates are included on the series titles (they aren’t in the staff PDF)

Here is a screenshot of the TOC from an exported pdf, the dates are shown in the bottom four entries:

ANW-1848-toc-dates

brianzelip
brianzelip approved these changes Jan 11, 2024
View reviewed changes
Copy link
Collaborator

@brianzelip brianzelip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @avatar382!

@brianzelip brianzelip merged commit 1258d0c into master Jan 11, 2024
11 checks passed
@brianzelip brianzelip deleted the ANW-1848 branch January 11, 2024 20:22
thimios pushed a commit that referenced this pull request Apr 4, 2024
@avatar382 @thimios
ANW-1848: Fix various PUI PDF bugs (#3078)
71322ff 
* bugfix for box not displaying in PUI PDF when folder isn't present
* adding missing notes to administrative info section
* spacing fixes, note fixes
* bugfix for dates appearing in PUI PDF TOC
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brianzelip brianzelip brianzelip approved these changes

Assignees

@brianzelip brianzelip

Labels
None yet
Projects
None yet
Milestone
3.5.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@avatar382 @brianzelip @cdibella