-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ANW-363 Add search terms in context #3080
Draft
stitching-coder
wants to merge
8
commits into
archivesspace:master
Choose a base branch
from
stitching-coder:ANW-363-search-terms-in-context
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
ANW-363 Add search terms in context #3080
stitching-coder
wants to merge
8
commits into
archivesspace:master
from
stitching-coder:ANW-363-search-terms-in-context
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stitching-coder
force-pushed
the
ANW-363-search-terms-in-context
branch
from
November 26, 2023 19:55
4b969ad
to
dc4561c
Compare
stitching-coder
force-pushed
the
ANW-363-search-terms-in-context
branch
from
November 26, 2023 23:52
ef9a43e
to
5c50d8f
Compare
stitching-coder
force-pushed
the
ANW-363-search-terms-in-context
branch
from
November 27, 2023 02:00
b63bada
to
6fdba33
Compare
brianzelip
requested review from
brianzelip
and removed request for
brianzelip
November 27, 2023 14:07
stitching-coder
changed the title
Add search terms in context
ANW-363 Add search terms in context
Dec 16, 2023
According to @stitching-coder this works for items already on the search results page and in some other types of data that have been extracted, as seen in screenshot 1. It is not working when a result comes from related agents and subjects, as seen in screenshot 4. The highlighting also doesn't carry over for some types of results due to issues with creating the referring URL. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Public interface search results should show search terms in context. Highlighting from Solr has been turned on for this feature.
Related JIRA Ticket or GitHub Issue
ANW-363
How Has This Been Tested?
Some manual testing has been done.
Screenshots (if appropriate):
Types of changes
Checklist: