Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide cfg to enable setting db pool timeout #3094

Merged

Conversation

mark-cooper
Copy link
Member

In cases where the db pool becomes full it can be helpful in some cases to increase the pool timeout to give the db connections addtl. time to complete before throwing pool timeout errors.

The default timeout is 5 which preserves the current cfg / behavior.

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have read the CONTRIBUTING document.
  • I have authority to submit this code.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

In cases where the db pool becomes full it can be
helpful in some cases to increase the pool timeout
to give the db connections addtl. time to complete
before throwing pool timeout errors.

The default timeout is 5 which preserves the current
cfg / behavior.
@brianzelip brianzelip added the config_changes PRs that include changes to config.rb/should be called out in release notes label Feb 2, 2024
Copy link
Collaborator

@brianzelip brianzelip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, anything to add @donaldjosephsmith?

Copy link
Collaborator

@donaldjosephsmith donaldjosephsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could definitely be useful.

@donaldjosephsmith donaldjosephsmith merged commit 6848dc8 into archivesspace:master Feb 7, 2024
10 checks passed
@cdibella cdibella added this to the 3.5.0 milestone Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
config_changes PRs that include changes to config.rb/should be called out in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants