Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixes / improvements for our flakky frontend specs #3099

Merged
merged 3 commits into from
Feb 6, 2024
Merged

fixes / improvements for our flakky frontend specs #3099

merged 3 commits into from
Feb 6, 2024

Conversation

thimios
Copy link
Collaborator

@thimios thimios commented Jan 31, 2024 •
edited

Description

Related JIRA Ticket or GitHub Issue

https://archivesspace.atlassian.net/browse/ANW-1895

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have read the CONTRIBUTING document.
  • I have authority to submit this code.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@thimios thimios changed the title drop all database tables for a much faster database nuke when using m… fixes for our flakky frontend specs Feb 1, 2024
@thimios thimios changed the title fixes for our flakky frontend specs fixes / improvements for our flakky frontend specs Feb 1, 2024
@thimios thimios force-pushed the ANW-1825-port-selenium-to-cucumber branch from 6d16d96 to d965a02 Compare February 1, 2024 16:28
@thimios thimios marked this pull request as ready for review February 1, 2024 19:51
@thimios thimios force-pushed the ANW-1825-port-selenium-to-cucumber branch from d965a02 to 78f3482 Compare February 2, 2024 17:23
@thimios
Copy link
Collaborator Author

thimios commented Feb 5, 2024

@donaldjosephsmith regarding the disabling of those specs I see it as a temporary measure until we really fix them:
https://archivesspace.atlassian.net/browse/ANW-1893

brianzelip
brianzelip previously approved these changes Feb 5, 2024
View reviewed changes
brianzelip
brianzelip previously approved these changes Feb 5, 2024
View reviewed changes
@thimios thimios force-pushed the ANW-1825-port-selenium-to-cucumber branch from cd30d1c to 91a34fc Compare February 5, 2024 19:20
brianzelip
brianzelip approved these changes Feb 6, 2024
View reviewed changes
Copy link
Collaborator

@brianzelip brianzelip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@thimios thimios merged commit 382162f into master Feb 6, 2024
15 checks passed
@thimios thimios deleted the ANW-1825-port-selenium-to-cucumber branch February 6, 2024 15:28
@cdibella cdibella added this to the 3.5.0 milestone Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brianzelip brianzelip brianzelip approved these changes

@mark-cooper mark-cooper Awaiting requested review from mark-cooper

@donaldjosephsmith donaldjosephsmith Awaiting requested review from donaldjosephsmith

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.5.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@thimios @donaldjosephsmith @brianzelip @cdibella