Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ANW-504: adding labels to primary agent links in frontend and PUI show views #3101

Merged
merged 1 commit into from
Mar 8, 2024

Conversation

avatar382
Copy link
Collaborator

@avatar382 avatar382 commented Feb 1, 2024

Description

Adding labels so primary agents can be easily distinguished

Related JIRA Ticket or GitHub Issue

https://archivesspace.atlassian.net/browse/ANW-504

How Has This Been Tested?

manual testing

Screenshots (if appropriate):

Screenshot_20240131_181126
Screenshot_20240229_090852

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have read the CONTRIBUTING document.
  • I have authority to submit this code.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@avatar382 avatar382 marked this pull request as draft February 1, 2024 18:11
@avatar382 avatar382 marked this pull request as ready for review February 29, 2024 16:12
Copy link
Collaborator

@thimios thimios left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the changes to the PUI should be removed, as the primary agent link should not be viewable on the Public User interface. As discussed, this would cause confusion and should be avoided.

@cdibella just to make sure that my understanding is correct, could you please confirm?

@cdibella cdibella added this to the 3.5.0 milestone Mar 4, 2024
@cdibella
Copy link
Contributor

cdibella commented Mar 4, 2024

yes, we want only the staff interface part at this time

@thimios
Copy link
Collaborator

thimios commented Mar 6, 2024

@avatar382 could you also rebase this branch to the release-v3.5.x branch and change the base of this PR to the release branch?

@the person who merges this PR: After this PR is merged please create a new PR to merge the release branch into master (unless such a PR is already open). See also: https://github.com/archivesspace/tech-docs/blob/master/development/release.md

@thimios
Copy link
Collaborator

thimios commented Mar 8, 2024

@avatar382 @cdibella as this is holding back the release, I will do the last piece of work needed here and push forward

@thimios thimios changed the base branch from master to release-v3.5.x March 8, 2024 11:54
@thimios thimios merged commit 06dc0eb into release-v3.5.x Mar 8, 2024
5 of 6 checks passed
@thimios thimios deleted the ANW-504-rework-2 branch March 8, 2024 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants