ANW-1830 Fix sort by username on the Manage User Access page #3110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brianzelip
force-pushed
the
ANW-1830-broken-sort
branch
from
712f948
to
28eef14
Compare
thimios
approved these changes
Feb 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the broken sort-by-username on the Manage user Access page by copying the
@search_datalogic from theindexaction to themanage_accessaction in the User controller.The original sort feature was only added to
index.Related JIRA Ticket or GitHub Issue
https://archivesspace.atlassian.net/browse/ANW-1830
How Has This Been Tested?
There is already a backend test for the server functionality.
Types of changes