Fix vertical jank in reorder mode row selection #3113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brianzelip
force-pushed
the
reorder-mode-vertical-jank
branch
from
ce04069
to
b7b781f
Compare
donaldjosephsmith
approved these changes
Feb 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the vertical jank/movement that happens in the Staff app in record reorder mode when an individual row is selected. It does so by rewriting the styles related to the row's drag handle. It also updates the drag handle grip icon svg to that which is used in the upcoming Softserv Staff fixes.
The need for this work was observed while working on the related ANW-1447 although it doesn't directly solve the issues in ANW-1447. Since work on ANW-1447 was halted via a recent staff meeting, this quick fix was pushed up.
Problem
Solution
How Has This Been Tested?
Manual in-browser
Types of changes