Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ANW-1879 fix title and action button label on accessions and component linkers #3114

Merged
merged 1 commit into from
Feb 9, 2024
Merged

ANW-1879 fix title and action button label on accessions and component linkers #3114

merged 1 commit into from
Feb 9, 2024

Conversation

thimios
Copy link
Collaborator

@thimios thimios commented Feb 8, 2024

Description

The title and the label on the "add link action" button are missing on:

  • /staff/accessions//edit#accession_component_links_
  • /staff/resources//edit#archival_object_accession_links_

Related JIRA Ticket or GitHub Issue

https://archivesspace.atlassian.net/browse/ANW-1879

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have read the CONTRIBUTING document.
  • I have authority to submit this code.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

brianzelip
brianzelip approved these changes Feb 9, 2024
View reviewed changes
Copy link
Collaborator

@brianzelip brianzelip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@brianzelip brianzelip merged commit 510fff5 into master Feb 9, 2024
11 checks passed
@cdibella cdibella added this to the 3.5.0 milestone Feb 12, 2024
thimios added a commit that referenced this pull request Apr 4, 2024
@thimios
ANW-1879 Fix title and label on accessions and component linkers (#3114)
832c43b
@thimios thimios deleted the ANW-1879-linking-components-modal branch April 30, 2024 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brianzelip brianzelip brianzelip approved these changes

@donaldjosephsmith donaldjosephsmith Awaiting requested review from donaldjosephsmith

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.5.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@thimios @brianzelip @cdibella