Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ANW-1878 - make primary tooltip adjustments #3119

Merged
merged 4 commits into from
Feb 13, 2024
Merged

ANW-1878 - make primary tooltip adjustments #3119

merged 4 commits into from
Feb 13, 2024

Conversation

cdibella
Copy link
Contributor

Description

Further changes for the other languages on this tooltip and label. I noticed some edits were needed once this was merged.

Related JIRA Ticket or GitHub Issue

https://archivesspace.atlassian.net/browse/ANW-1878

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have read the CONTRIBUTING document.
  • I have authority to submit this code.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@cdibella cdibella marked this pull request as ready for review February 13, 2024 19:43
brianzelip
brianzelip approved these changes Feb 13, 2024
View reviewed changes
Copy link
Collaborator

@brianzelip brianzelip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🗣️

@brianzelip brianzelip merged commit a2c170e into master Feb 13, 2024
11 checks passed
@brianzelip brianzelip deleted the ANW1878onlynew branch February 13, 2024 20:18
@cdibella cdibella added this to the 3.5.0 milestone Feb 13, 2024
thimios pushed a commit that referenced this pull request Apr 4, 2024
@cdibella @thimios
ANW-1878 Add make primary tooltip translations (#3119)
591d59b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brianzelip brianzelip brianzelip approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.5.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@cdibella @brianzelip