-
Notifications
You must be signed in to change notification settings - Fork 223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ANW-1869 support emphasis styling in PUI breadcrumbs #3120
Conversation
Users expect mixed content in titles to be rendered properly in the breadcrumbs shown on the "found in" section for the digital materials in a collection. This was not previously accounted for.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@donaldjosephsmith I noticed from loading up this code that the resulting breadcrumb isn't italicized like is shown in your 'after' picture here in the PR write up. Looking at the 'before' picture above I see that there are two classes added to the (.italic
, .emph
), but there is only one class in the markup from this PR code (.emph
-- see my screenshot in the comment below) -- looks like .italic
needs to be added.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@donaldjosephsmith There are also related breadcrumbs on the digital object page as well under the "Linked Records" section. These should get updated with the mixed_content_parser
too. (The url for the screenshot below looks like: http://localhost:3001/repositories/2/digital_objects/25)
NEVERMIND! I see that adding |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work!
Users expect mixed content in titles to be rendered properly in the breadcrumbs shown on the "found in" section for the digital materials in a collection. This was not previously accounted for. Two things needed to be done:
emph
tags in collection titlesspan
tags used for the formatting outside of the breadcrumb links so they render properlybefore:
after: